Ender rain damage is unreliable #15

New issue

Closed

opened 2019-01-28 19:17:58 -05:00 by kennyrkun · 1 comment

kennyrkun commented

2019-01-28 19:17:58 -05:00

(Migrated from github.com)

Description
Ender people are supposed to be vulnerable to rain. Instead of being teleported away like regular Endermen, they are simply damaged in the rain. It's not reliable for some reason, I don't know why. It might be caused by switching game modes, but I don't know.

Steps to reproduce the behavior:

Be Ender
Go into the rain.

Expected behaviour
The player should be damaged once per second (or tick I can't remember)

**Description** Ender people are supposed to be vulnerable to rain. Instead of being teleported away like regular Endermen, they are simply damaged in the rain. It's not reliable for some reason, I don't know why. It might be caused by switching game modes, but I don't know. **Steps to reproduce the behavior:** 1. Be Ender 2. Go into the rain. **Expected behaviour** The player should be damaged once per second (or tick I can't remember)

kennyrkun commented

2019-02-16 13:16:53 -05:00

(Migrated from github.com)

the code here is probably what's causing the issue:
github.com/kennyrkun/Erostey@7e9c2bfe70/src/main/java/io/github/kennyrkun/erostey/species/ender/Ender.java (L283-L284)

I believe this also causes issues for Elves, here:
github.com/kennyrkun/Erostey@7e9c2bfe70/src/main/java/io/github/kennyrkun/erostey/species/Elf.java (L122-L123)

simply replacing return with continue should resolve the issue.

the code here is probably what's causing the issue: https://github.com/kennyrkun/Erostey/blob/7e9c2bfe70f92a765e8db984a480457ae2e9d93f/src/main/java/io/github/kennyrkun/erostey/species/ender/Ender.java#L283-L284 I believe this also causes issues for Elves, here: https://github.com/kennyrkun/Erostey/blob/7e9c2bfe70f92a765e8db984a480457ae2e9d93f/src/main/java/io/github/kennyrkun/erostey/species/Elf.java#L122-L123 simply replacing `return` with `continue` should resolve the issue.

This discussion has been locked. Commenting is limited to contributors.