Enchanted books do not work when crafting in stacks #35

New issue

Closed

opened 2019-05-23 09:19:56 -04:00 by kennyrkun · 1 comment

kennyrkun commented

2019-05-23 09:19:56 -04:00

(Migrated from github.com)

Description
When crafting books Elves have a slight chance of crafting enchanted books instead. If more than a single book's worth or materials are placed in the crafting table, and the result if shift-placed into the inventory, no enchanted books will be given.

To Reproduce

Put enough materials to craft a stack of books into a crafting table.
Shift-click the result into your inventory

Expected behavior
A few enchanted books will come out.

I believe this could be a design issue as well. If the player creates more than one book at a time, should we even give them some enchanted books? When you create several books at a time, they come in a stack. However, if we add enchanted books, the user will receive more than one item at a time, which is not normally the behaviour of crafted items. Do we want to do this? I don't really think we should.

I think the best solution might be to completely remove the random chance of getting enchanted books, and instead implement another system which lets them create enchanted books outright.

**Description** When crafting books Elves have a slight chance of crafting enchanted books instead. If more than a single book's worth or materials are placed in the crafting table, and the result if shift-placed into the inventory, no enchanted books will be given. **To Reproduce** 1. Put enough materials to craft a stack of books into a crafting table. 2. Shift-click the result into your inventory **Expected behavior** A few enchanted books will come out. --- I believe this could be a design issue as well. If the player creates more than one book at a time, should we even give them some enchanted books? When you create several books at a time, they come in a stack. However, if we add enchanted books, the user will receive more than one item at a time, which is not normally the behaviour of crafted items. Do we want to do this? I don't really think we should. I think the best solution might be to completely remove the random chance of getting enchanted books, and instead implement another system which lets them create enchanted books outright.

kennyrkun commented

2019-06-22 13:31:57 -04:00

(Migrated from github.com)

as of 8a7e95d3d1, Elves cannot craft enchanted books.

as of 8a7e95d3d1114b1e66c0a8d0ce17eb91072420f1, Elves cannot craft enchanted books.

This discussion has been locked. Commenting is limited to contributors.